Press n or j to go to the next uncovered block, b, p or k for the previous block.
| 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 | 148x 148x 148x 148x 148x 148x 148x 148x 148x 148x 148x 90x 2x 3x 2x 148x 3x 1x 1x 1x 148x 2x 1x 1x 1x 1x 148x 148x 11x 148x 49x 99x 1x 98x 5x 1x 97x 194x 4x 4x 2x 2x 4x 4x 1x 1x 5x 2x 1x 2x 2x 2x 1x 1x 1x 1x 1x 1x 1x 1x 1x | import { ArrowRightLeft } from "lucide-react";
import { useEffect, useState } from "react";
import { useConfirmDialog } from "../../hooks";
import type { Project, Room } from "../../lib/api";
import { MediaLightbox } from "../rooms/MediaLightbox";
import { RoomFormModal } from "../rooms/RoomFormModal";
import { RoomMediaDrawer } from "../rooms/RoomMediaDrawer.subcomponent";
import { Alert } from "../ui/alert";
import { Button } from "../ui/button";
import { Skeleton } from "../ui/skeleton";
import { RoomCard } from "./RoomCard.subcomponent";
import { RoomEditorModal } from "./RoomEditorModal";
import type { ProjectApiAdapter } from "./types";
import { useRoomMedia } from "./use-room-media.hook";
import {
UNCLASSIFIED_ROOM_TYPE,
useProjectRooms,
} from "./use-project-rooms.hook";
/**
* The Photos tab — `project-detail-photos.html` (plan §1.7 item 3, 5.9).
*
* WHAT CHANGED
* One 498-line component held the card markup, the drag state, the room CRUD,
* the legacy convert and a centred media modal. It is now three pieces:
*
* - `RoomCard.subcomponent.tsx` — one room's card, edited IN PLACE
* - `use-project-rooms.hook.ts` — load, CRUD, reorder, legacy convert
* (including the derive-don't-guess fix; do NOT reintroduce the
* `roomType: "living_room"` hardcode it replaced)
* - `rooms/RoomMediaDrawer.subcomponent.tsx` — one room's bulk media work,
* in a right-side drawer rather than a modal inside a tab inside a page
*
* and this, the grid that composes them.
*/
type RoomCardsGridProps = {
project: Project & { photos: unknown[] };
proId: string;
supportsRooms: boolean;
apiAdapter: ProjectApiAdapter;
onSave: (data: Partial<Project>) => Promise<void>;
onTotalMediaChange?: (count: number) => void;
};
export function RoomCardsGrid({
project,
proId,
supportsRooms,
apiAdapter,
onSave,
onTotalMediaChange,
}: RoomCardsGridProps) {
const { confirm, dialog: confirmDialog } = useConfirmDialog();
const {
fileInputRefs,
uploadingRoomId,
managingRoom,
setManagingRoom,
managingRoomMedia,
roomMediaMap,
loadAllRoomMedia,
handleFileSelect,
openMediaManager,
handleMediaManagerChange,
} = useRoomMedia(proId);
const {
rooms,
roomTypes,
isLoading,
isSubmitting,
draggedRoomId,
dragOverRoomId,
savingRoomTypeId,
getRoomTypeName,
addRoom,
deleteRoom,
setFeaturedRoom,
updateRoom,
saveRoomType,
onRoomDragStart,
onRoomDragEnd,
onRoomDragOver,
onRoomDrop,
hasLegacyPhotos,
convertLegacyPhotos,
} = useProjectRooms({
project,
proId,
apiAdapter,
onSave,
confirm,
reloadMedia: loadAllRoomMedia,
});
const [isAddModalOpen, setIsAddModalOpen] = useState(false);
const [newRoomType, setNewRoomType] = useState("");
const [newRoomName, setNewRoomName] = useState("");
const [editingRoom, setEditingRoom] = useState<Room | null>(null);
const [lightboxRoomId, setLightboxRoomId] = useState<number | null>(null);
const [lightboxIndex, setLightboxIndex] = useState(0);
/** The in-place classification picker, per room. */
const [pendingRoomTypes, setPendingRoomTypes] = useState<
Record<number, string>
>({});
// The project's photo figure, reported up for the publish gate and the tab
// rail. Only images count — three videos are not three photos, which is the
// server's own definition in `lib/publish-readiness.ts`.
useEffect(() => {
if (!onTotalMediaChange) return;
const total = Object.values(roomMediaMap).reduce(
(sum, items) =>
sum + items.filter((m) => m.mediaType === "image").length,
0,
);
onTotalMediaChange(total);
}, [roomMediaMap, onTotalMediaChange]);
const handleAddRoom = async () => {
if (await addRoom(newRoomType, newRoomName)) {
setNewRoomType("");
setNewRoomName("");
setIsAddModalOpen(false);
}
};
const handleSaveRoomType = async (roomId: number) => {
if (await saveRoomType(roomId, pendingRoomTypes[roomId] ?? "")) {
setPendingRoomTypes((prev) => {
const next = { ...prev };
delete next[roomId];
return next;
});
}
};
const lightboxMedia =
lightboxRoomId !== null ? roomMediaMap[lightboxRoomId] || [] : [];
const managingIndex = managingRoom
? rooms.findIndex((r) => r.id === managingRoom.id)
: -1;
if (isLoading) {
return (
<div className="grid gap-4 sm:grid-cols-2">
<Skeleton className="h-48 w-full" />
<Skeleton className="h-48 w-full" />
</div>
);
}
if (!supportsRooms) {
return (
<p className="py-8 text-center text-sm text-foreground-muted">
Room management is not available.
</p>
);
}
return (
<>
<div className="space-y-4">
{hasLegacyPhotos && (
<Alert variant="warning" title="Convert to rooms layout">
<p>
This project has {project.photos.length} photos but no rooms.
Convert to the rooms layout to organise photos by room and
unlock room-level detail.
</p>
<Button
size="sm"
variant="outline"
className="mt-3 h-8"
onClick={convertLegacyPhotos}
>
<ArrowRightLeft aria-hidden="true" />
Convert to rooms
</Button>
</Alert>
)}
<div className="flex flex-wrap items-start justify-between gap-3">
<p className="max-w-[46ch] text-sm text-foreground-muted">
Rooms and their photos edit here, in place. Drag a photo to
reorder it; the first photo is that room's cover.
</p>
<Button
size="sm"
className="h-8"
onClick={() => setIsAddModalOpen(true)}
>
Add room
</Button>
</div>
{rooms.length === 0 ? (
<button
type="button"
onClick={() => setIsAddModalOpen(true)}
className="flex w-full flex-col items-center justify-center gap-1 rounded-md border border-dashed border-input bg-background-subtle py-12 text-sm text-foreground-muted hover:border-foreground-default hover:bg-foreground-default/7"
>
<span>Add the first room</span>
<span className="text-xs font-semibold uppercase tracking-wider text-foreground-subtle">
A room is one area you worked on
</span>
</button>
) : (
<div className="grid gap-4 lg:grid-cols-2">
{rooms.map((room) => (
<RoomCard
key={room.id}
room={room}
media={roomMediaMap[room.id] || []}
isDefault={project.defaultRoomId === room.id}
isUploading={uploadingRoomId === room.id}
isDragOver={dragOverRoomId === room.id}
isDragging={draggedRoomId === room.id}
isCurrent={managingRoom?.id === room.id}
fileInputRef={(el) => {
fileInputRefs.current[room.id] = el;
}}
getRoomTypeName={getRoomTypeName}
onDragStart={(e) =>
onRoomDragStart(room.id, (effect) => {
e.dataTransfer.effectAllowed =
effect as typeof e.dataTransfer.effectAllowed;
})
}
onDragEnd={onRoomDragEnd}
onDragOver={(e) => {
e.preventDefault();
onRoomDragOver(room.id);
}}
onDrop={(e) => {
e.preventDefault();
void onRoomDrop(room.id);
}}
onOpenLightbox={(idx) => {
setLightboxRoomId(room.id);
setLightboxIndex(idx);
}}
onUploadClick={() => fileInputRefs.current[room.id]?.click()}
onOpenMediaManager={() => openMediaManager(room)}
onSetFeatured={() => setFeaturedRoom(room.id)}
onEdit={() => setEditingRoom(room)}
onDelete={() => deleteRoom(room.id)}
onFileSelect={(e) => handleFileSelect(room.id, e)}
needsClassification={room.roomType === UNCLASSIFIED_ROOM_TYPE}
roomTypes={roomTypes}
pendingRoomType={pendingRoomTypes[room.id] ?? ""}
onPendingRoomTypeChange={(code) =>
setPendingRoomTypes((prev) => ({ ...prev, [room.id]: code }))
}
onSaveRoomType={() => handleSaveRoomType(room.id)}
isSavingRoomType={savingRoomTypeId === room.id}
/>
))}
</div>
)}
</div>
{lightboxRoomId !== null && lightboxMedia.length > 0 && (
<MediaLightbox
media={lightboxMedia}
currentIndex={lightboxIndex}
onClose={() => setLightboxRoomId(null)}
onNext={() => setLightboxIndex((i) => (i + 1) % lightboxMedia.length)}
onPrev={() =>
setLightboxIndex(
(i) => (i - 1 + lightboxMedia.length) % lightboxMedia.length,
)
}
/>
)}
<RoomFormModal
isOpen={isAddModalOpen}
editingRoom={null}
newRoomType={newRoomType}
newRoomName={newRoomName}
roomTypes={roomTypes}
isSubmitting={isSubmitting}
onClose={() => {
setIsAddModalOpen(false);
setNewRoomType("");
setNewRoomName("");
}}
onSubmit={handleAddRoom}
onRoomTypeChange={setNewRoomType}
onRoomNameChange={setNewRoomName}
/>
{editingRoom && (
<RoomEditorModal
isOpen={editingRoom !== null}
room={editingRoom}
roomTypes={roomTypes}
onClose={() => setEditingRoom(null)}
onSave={async (data) => {
await updateRoom(editingRoom.id, data);
}}
/>
)}
{/* One room's bulk media work — a right-side drawer, not a centred
modal inside a tab inside a page. */}
{managingRoom && (
<RoomMediaDrawer
open
onClose={() => setManagingRoom(null)}
proId={proId}
room={managingRoom}
media={managingRoomMedia}
roomTypeName={getRoomTypeName(managingRoom.roomType)}
onMediaChange={handleMediaManagerChange}
projectTitle={project.title}
roomPosition={managingIndex + 1}
roomCount={rooms.length}
/>
)}
{confirmDialog}
</>
);
}
|